Change in vdsm[master]: mkimage: ignore '\r' calculating content signature

fromani at redhat.com fromani at redhat.com
Thu Oct 16 12:38:06 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: mkimage: ignore '\r' calculating content signature
......................................................................


Patch Set 1: Verified+1

verification:

- patched a couple of 3.5.0 VDSMs (last rc), but code is identical as master
- created a brand new VM on a host configured to use JSON-RPC communication; verified that cloud-init is enabled (as it is),
booted VM
- migrated VM to another host, thus using xml-rpc
- verified using virsh dumpxml that the device path is not lost and matches the one computed on the source

On top of that, this fix is nicely covered by the added unit test, which uses data extracted by actual VDSM logs.

-- 
To view, visit http://gerrit.ovirt.org/34203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dfd32eacd5c5a01d0ba27a8403a46d4bea02ab
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list