Change in vdsm[master]: vdsm: add functionality to detach host devices

danken at redhat.com danken at redhat.com
Wed Oct 15 23:03:29 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: add functionality to detach host devices
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/32389/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-09-03 14:58:40 +0200
Line 4: Commit:     Martin Polednik <mpolednik at redhat.com>
Line 5: CommitDate: 2014-10-13 16:50:38 +0200
Line 6: 
Line 7: vdsm: add functionality to detach host devices
"vdsm:" prefix is pointless, please drop it.

Please use a consistent spelling for "dettach" (same as the one chosen by libvirt)
Line 8: 
Line 9: Detach call (libvirt's dettach call) is required to properly
Line 10: detach device from host. Dettaching device from the host means
Line 11: unbinding it from it's driver and binding it to VFIO driver, which


Line 7: vdsm: add functionality to detach host devices
Line 8: 
Line 9: Detach call (libvirt's dettach call) is required to properly
Line 10: detach device from host. Dettaching device from the host means
Line 11: unbinding it from it's driver and binding it to VFIO driver, which
it's -> its
Line 12: serves as KVM device driver.
Line 13: 
Line 14: Change-Id: I530fed56831314286942b8afa62900208812bfb5


-- 
To view, visit http://gerrit.ovirt.org/32389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I530fed56831314286942b8afa62900208812bfb5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list