Change in vdsm[master]: supervdsm: Add zombiereaper to supervdsm

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 15 12:44:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: supervdsm: Add zombiereaper to supervdsm
......................................................................


Patch Set 16: Code-Review+1

(1 comment)

http://gerrit.ovirt.org/#/c/28915/16/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 258: 
Line 259:         finally:
Line 260:             # Add to zombiereaper if process has not been waited upon
Line 261:             if proc.exitcode is None:
Line 262:                 zombiereaper.autoReapPID(proc.pid)
Maybe we need a context manager for this pattern.

    proc.start()
    with terminating(proc):
        do stuff with proc

The context manager can terminate the process and pass the pid to zombiereaper if needed.
Line 263: 
Line 264:     @logDecorator
Line 265:     def validateAccess(self, user, groups, *args, **kwargs):
Line 266:         return self._runAs(user, groups, _validateAccess, args=args,


-- 
To view, visit http://gerrit.ovirt.org/28915
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5333caf7a1162c5d783f556bb9204fb74d1ab469
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list