Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

mbetak at redhat.com mbetak at redhat.com
Wed Oct 15 10:30:58 UTC 2014


Martin Betak has posted comments on this change.

Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/31992/5/vdsm/API.py
File vdsm/API.py:

Line 504:             *mode* - ``remote``/``file``
Line 505:             *method* - ``online``
Line 506:             *downtime* - allowed down time during online migration
Line 507:             *dstqemu* - remote host address dedicated for migration
Line 508:             *compressed* - compress repeated pages during live migration
> Why here and not after autoConverge?
Yeah, for some reason I followed the order in which the libvirt features were implemented. (in case we wanted to differentiate between XZBRLE (supported in RHEL 7.0) and auto-convergence (supported in RHEL 7.1), unfortunately I swapped the order of patches and since both features will be in the same cluster level it no longer makes a difference.
Line 509:             *autoConverge* - force convergence during live migration
Line 510:         """
Line 511:         params['vmId'] = self._UUID
Line 512:         self.log.debug(params)


-- 
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5391e7966dd46d7b33962fb3adf2830381472247
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list