Change in vdsm[master]: supervdsmServer: Do not use udev to set permissions on exter...

danken at redhat.com danken at redhat.com
Tue Oct 14 14:00:20 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: supervdsmServer: Do not use udev to set permissions on external luns
......................................................................


supervdsmServer: Do not use udev to set permissions on external luns

Before plugging external luns to vms, we setup up a temporary udev rule
for setting device permissions. Using this rule will cause the device to
loose the libvirt selinux label if a device has a change event.

This is the same issue we had with vdsm images, but with external luns
we do not trigger change events, so the issue is unlikely. However, if
it happens, it will cause a vm to pause.

This patch applies the same fix, use chown instead of udev USER and
GROUP directives.

Change-Id: I7adb8a441497c9dd335119f55af73189ed89c23c
Relates-To: http://gerrit.ovirt.org/33875
Relates-To: https://bugzilla.redhat.com/1147910
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33994
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/supervdsmServer
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/33994
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7adb8a441497c9dd335119f55af73189ed89c23c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list