Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

fromani at redhat.com fromani at redhat.com
Tue Oct 14 13:14:39 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

on overall I'm fine, not worth delaying this patch for some silly nitpicking of mine

http://gerrit.ovirt.org/#/c/31992/5/vdsm/API.py
File vdsm/API.py:

Line 508:  
Why here and not after autoConverge?
However I don't really care enough, not worth a resubmit for this.


http://gerrit.ovirt.org/#/c/31992/5/vdsm/caps.py
File vdsm/caps.py:

Line 732:         return _dropVersion('3.6',
Line 733:                             'VIR_MIGRATE_COMPRESSED not found in libvirt,'
Line 734:                             ' support for clusterLevel >= 3.6 is disabled.'
Line 735:                             ' For Fedora 20 users, please consider upgrading'
Line 736:                             ' libvirt from the virt-preview repository')
not worth refactoring this still, but on the next flag we should.
Line 737: 
Line 738:     return dsaversion.version_info
Line 739: 
Line 740: 


http://gerrit.ovirt.org/#/c/31992/5/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 57: 
Line 58:     def __init__(self, vm, dst='', dstparams='',
Line 59:                  mode=MODE_REMOTE, method=METHOD_ONLINE,
Line 60:                  tunneled=False, dstqemu='', abortOnError=False,
Line 61:                  compressed=False, autoConverge=False, **kwargs):
same comment as per API.py
Line 62:         self.log = vm.log
Line 63:         self._vm = vm
Line 64:         self._dst = dst
Line 65:         self._mode = mode


-- 
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5391e7966dd46d7b33962fb3adf2830381472247
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list