Change in vdsm[master]: tool: extend ModuleConfigurer documentation.

nsoffer at redhat.com nsoffer at redhat.com
Tue Oct 14 09:35:04 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tool: extend ModuleConfigurer documentation.
......................................................................


Patch Set 2: Code-Review-1

This does two unrelated changes:
1. Change the indentation of existing docstrings from:

    """
    first line

    more lines...
    """

To:

    """first line
 
    more lines...
    """

This change is not required for extending documentation. More, it is a bad change and not required by pep8 - both style of docstrings are valid (otherwise pep8 tool would fail the build).

This is an issue of style - when you edit other people code, you respect their style.

2. Extend documentation - looks good on brief read

Please focus on the purpose of this patch and use the style already used
in this module.

If you want to do style changes, suggest them in a separate patch.

-- 
To view, visit http://gerrit.ovirt.org/34045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f4da9a7a2a7917c354137833d66edf0fbc95510
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list