Change in vdsm[master]: tool: change configurators from classes to modules.

dkuznets at redhat.com dkuznets at redhat.com
Tue Oct 14 05:47:40 UTC 2014


Dima Kuznetsov has posted comments on this change.

Change subject: tool: change configurators from classes to modules.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/34047/2/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 65: s
I think rather than looking at defaults around the code, it'll be easier for the module developer to decide what parts to implement if each member description would contain "What vdsm-tool will assume if it is missing?" part.


-- 
To view, visit http://gerrit.ovirt.org/34047
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff5d588cfbbcfe0d5f4a90d624d24f21ef4cc580
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list