Change in vdsm[master]: tool: change enumeration naming.

mtayer at redhat.com mtayer at redhat.com
Mon Oct 13 18:21:47 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: change enumeration naming.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/34046/1/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:

Line 34: #
Line 35: # NO    = Module is not set properly for VDSM and need to be configured.
Line 36: #
Line 37: # MAYBE = VDSM configured module already, but on force configure vdsm will
Line 38: #         set configurations to defaults parameters.
> It does not make any sense. Probably needs better documentation, or should 
Since we have this comment on the former change we can
ignore it here.
Line 39: #
Line 40: YES, NO, MAYBE = range(3)
Line 41: 
Line 42: 


-- 
To view, visit http://gerrit.ovirt.org/34046
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74369c88f149f6c04107019ef66ea42aab5b0405
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list