Change in vdsm[master]: tool: extend ModuleConfigurer documentation.

mtayer at redhat.com mtayer at redhat.com
Mon Oct 13 17:50:41 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tool: extend ModuleConfigurer documentation.
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.ovirt.org/#/c/34045/1/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:

Line 36: #                  force.
Line 37: # NOT_CONFIGURED = Module is not set properly for VDSM and need to be
Line 38: #                  configured.
Line 39: # NOT_SURE       = VDSM configured module already but on force configure vdsm
Line 40: #                  will set configurations to defaults parameters.
> I suggest that this *will* be part of your changes.
Now that I've explained in 34046 do you have a better
suggestion? To me this looks clear.
Line 41: #
Line 42: CONFIGURED, NOT_CONFIGURED, NOT_SURE = range(3)
Line 43: 
Line 44: 


Line 51:     - Check configuration status and validity during init.
Line 52:     """
Line 53:     @property
Line 54:     def name(self):
Line 55:         """Return module name to be used with the --module option.
> This is bad example, don't follow it. The original code was fine, please do
@Yaniv? @saggi? 
What is your view on this?
Line 56: 
Line 57:         Must be overridden by subclass.
Line 58:         """
Line 59:         raise NotImplementedError()


Line 101: 
Line 102:         see possible values above.
Line 103: 
Line 104:         Note: returning NOT_CONFIGURED or NOT_SURE will cause vdsm to abort
Line 105:         during initialization( the latter only if --force is not ).
> This is actually not true, will revise.
Done
Line 106: 
Line 107:         Note: after configure isconfigured should return NOT_SURE or
Line 108:         CONFIGURED.
Line 109: 


-- 
To view, visit http://gerrit.ovirt.org/34045
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f4da9a7a2a7917c354137833d66edf0fbc95510
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list