Change in vdsm[master]: toolTests: change boolean logic.

danken at redhat.com danken at redhat.com
Sun Oct 12 20:40:09 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: toolTests: change boolean logic.
......................................................................


toolTests: change boolean logic.

1. change  should_fail to should_succeed.
2. change
if !should_fail:
    return True
return False

to:
return should_succeed

Change-Id: I6362c94ceee397908b03b5267363091ce892d024
Signed-off-by: Mooli Tayer <mtayer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/34042
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/toolTests.py
1 file changed, 10 insertions(+), 12 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  mooli tayer: Verified
  Dima Kuznetsov: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/34042
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6362c94ceee397908b03b5267363091ce892d024
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list