Change in vdsm[master]: setupNetworks: doesn't remove broken nw from runningConfig
asegurap at redhat.com
asegurap at redhat.com
Fri Oct 10 14:11:28 UTC 2014
Antoni Segura Puimedon has posted comments on this change.
Change subject: setupNetworks: doesn't remove broken nw from runningConfig
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
Just a change in the commit msg
http://gerrit.ovirt.org/#/c/33995/6//COMMIT_MSG
Commit Message:
Line 9: network/api.py:setupNetworks() removes broken networks - if network
Line 10: is not listed in netinfo, but it's in libvirt, _delBrokenNetwork()
Line 11: is called.
Line 12:
Line 13: Problem is, that _delBrokenNetwork() removes network only from libvirt
"The problem is that when the network doesn't have an existing device, we only remove it from libvirt and leave it in RunningConfig."
Line 14: but leaves it in runningConfig. Due to this problem, we might get
Line 15: exceptions while restore-persistent-conf.
Line 16:
Line 17: Now _delBrokenNetwork() remove broken network from runningConfig.
--
To view, visit http://gerrit.ovirt.org/33995
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0c507626705d7ead84db2f3aa15e4032f9558d12
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list