Change in vdsm[master]: caps: Report online logical CPUs

danken at redhat.com danken at redhat.com
Fri Oct 10 08:22:13 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: caps: Report online logical CPUs
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/33789/2/vdsm/caps.py
File vdsm/caps.py:

Line 221: def _getCapsXMLStr():
Line 222:     return libvirtconnection.get().getCapabilities()
Line 223: 
Line 224: 
Line 225: @utils.memoized
> The CPUs can change their state at any time, this fix is just enough for Po
how adding another libvirt call (to _getCpuTopology) is going to hasten things up? If we need to recalculate the topology, so be it; please find an inexpensive solution to the problem. We need it on Intel too, in order to support host-side CPU hot-plugging.
Line 226: def _getCpuTopology(capabilities):
Line 227:     if capabilities is None:
Line 228:         capabilities = _getCapsXMLStr()
Line 229: 


-- 
To view, visit http://gerrit.ovirt.org/33789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia41df1758e629dc1087416c1dad3fa4d115243fb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list