Change in vdsm[master]: virt: sampling: consolidate disk statistics

nsoffer at redhat.com nsoffer at redhat.com
Thu Oct 9 14:27:49 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: virt: sampling: consolidate disk statistics
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.ovirt.org/#/c/29953/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 299:             # depending on is ok with that. Quoting libvirt header:
Line 300:             # """Older servers lacked the ability to handle string typed
Line 301:             # parameters.[...] This flag is automatically set when needed,
Line 302:             # [...] however, manually setting the flag can be used to
Line 303:             # reject servers that cannot return typed strings [...]"""
> Thanks for the verbose explanation!,
Hmm, according to the current patch, the line with this cryptic flag already exists in the older code, but in version 5 (http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py), it was new. Is this a result of a rebase?

If this patch does not add this flag, there is no point to add the documentation here, and it is best done in a separate documentation patch (which does not need verification).
Line 304:         return diskSamples
Line 305: 
Line 306:     def _sampleNet(self):
Line 307:         netSamples = {}


-- 
To view, visit http://gerrit.ovirt.org/29953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list