Change in vdsm[master]: blockVolume: remove inexplicable fixme comment

Federico Simoncelli fsimonce at redhat.com
Wed Oct 8 21:45:38 UTC 2014


Federico Simoncelli has uploaded a new change for review.

Change subject: blockVolume: remove inexplicable fixme comment
......................................................................

blockVolume: remove inexplicable fixme comment

There's no apparent reason for this fixme. Since the line is raising an
exception the "fix me" string appears in the tracebacks making our code
appear sloppy.

I searched for other inexplicable fixmes but it seems that this was the
only one.

Change-Id: I39c5a2034fdc7e5300259a2c5a25b0aed7f679b6
Signed-off-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/storage/blockVolume.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/33949/1

diff --git a/vdsm/storage/blockVolume.py b/vdsm/storage/blockVolume.py
index d741e49..2bb9a78 100644
--- a/vdsm/storage/blockVolume.py
+++ b/vdsm/storage/blockVolume.py
@@ -85,7 +85,7 @@
         try:
             lvm.getLV(self.sdUUID, self.volUUID)
         except se.LogicalVolumeDoesNotExistError:
-            raise se.VolumeDoesNotExist(self.volUUID)  # Fix me
+            raise se.VolumeDoesNotExist(self.volUUID)
         volume.Volume.validate(self)
 
     def refreshVolume(self):


-- 
To view, visit http://gerrit.ovirt.org/33949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I39c5a2034fdc7e5300259a2c5a25b0aed7f679b6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list