Change in vdsm[master]: modularize configurators: draft.

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 8 21:31:45 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: modularize configurators: draft.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33914/2//COMMIT_MSG
Commit Message:

Line 20: 
Line 21: The main issue of this draft is Classes morphing into Modules:
Line 22: * When a new implementation is needed, it should be sufficient to look at
Line 23:       configurator.py To understand what is needed. Code at package __init__
Line 24:       that has lower visibility and  has been trimmed.
Moving stuff from __init__ would be make another patch.

Puting the base class in base.py will make it more clear (base.Configuratior).

Other stuff in __init__ should probably have another module to live (constants|whatever).

__init__.py is best when empty, then you don't have to check if some code is hidden there.
Line 25: * configurator.py contains the default values it uses.
Line 26: * Modules are simpler and can use classes if they need (e.g libvirt),
Line 27:       the opposite is not true. Initialization is also simpler
Line 28:       (name() vs. name.Configurator).


-- 
To view, visit http://gerrit.ovirt.org/33914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b2b2b94431f290f922a2e5e7670be290763e59
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list