Change in vdsm[master]: modularize configurators: draft.

mtayer at redhat.com mtayer at redhat.com
Tue Oct 7 23:46:17 UTC 2014


mooli tayer has posted comments on this change.

Change subject: modularize configurators: draft.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/33914/1/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 40: installation life cycle of one aspect of vdsm.
Line 41: 
Line 42: Modules are used to:
Line 43: - Configure the machine to run vdsm and cleanup configuration after removal.
Line 44: - The configuration's status and validity at vdsm init.
- Check configuration status ..
Line 45: 
Line 46: Module configurators should implement:
Line 47: 
Line 48: [optional attribute] requires:


http://gerrit.ovirt.org/#/c/33914/1/lib/vdsm/tool/configurators/sanlock.py
File lib/vdsm/tool/configurators/sanlock.py:

remove self references.
Line 1: # Copyright 2014 Red Hat, Inc.
Line 2: #
Line 3: # This program is free software; you can redistribute it and/or modify
Line 4: # it under the terms of the GNU General Public License as published by


-- 
To view, visit http://gerrit.ovirt.org/33914
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66b2b2b94431f290f922a2e5e7670be290763e59
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list