Change in vdsm[master]: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter

danken at redhat.com danken at redhat.com
Tue Oct 7 14:07:16 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Add support for VIR_MIGRATE_COMPRESSED parameter
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/31992/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 341:                 (libvirt.VIR_MIGRATE_TUNNELLED if
Line 342:                     self._tunneled else 0) |
Line 343:                 (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if
Line 344:                     self._abortOnError else 0) |
Line 345:                 (libvirt.VIR_MIGRATE_COMPRESSED if
The same comment applies to this patch: we should not expose clusterLevel 3.6 if libvirt.VIR_MIGRATE_COMPRESSED is undefined.
Line 346:                     self._compressed else 0) |
Line 347:                 (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
Line 348:                     self._autoConverge else 0),
Line 349:                 None, maxBandwidth)


-- 
To view, visit http://gerrit.ovirt.org/31992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5391e7966dd46d7b33962fb3adf2830381472247
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list