Change in vdsm[master]: Move multipath configuration to vdsm-tool configurator

danken at redhat.com danken at redhat.com
Tue Oct 7 12:11:10 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Move multipath configuration to vdsm-tool configurator
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.ovirt.org/#/c/30909/13/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 124:             first, second = self._parseConf()
Line 125:             if not os.path.exists(self._CONF_BACKUP) and \
Line 126:                     self._MPATH_CONF_TAG not in first:
Line 127:                 cmd = [constants.EXT_CP, self._MPATH_CONF, self._CONF_BACKUP]
Line 128:                 rc, out, err = utils.execCmd(cmd)
> If we cannot write multipath configuration file running as root, something 
Right, and there's no reason to use execCmd imo - shutil.copy() should be enough.
Line 129:                 utils.persistFile(self._CONF_BACKUP)
Line 130: 
Line 131:         with tempfile.NamedTemporaryFile() as f:
Line 132:             f.write(self._MPATH_CONF_TEMPLATE %


-- 
To view, visit http://gerrit.ovirt.org/30909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife045908dc6e2aea9829b51482b909af1faf79da
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list