Change in vdsm[master]: Introduction for caching the parsed domain XML

danken at redhat.com danken at redhat.com
Tue Oct 7 10:51:55 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: Introduction for caching the parsed domain XML
......................................................................


Patch Set 25:

(1 comment)

http://gerrit.ovirt.org/#/c/17694/25/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:

Line 40:     @property
Line 41:     def dom(self):
Line 42:         return self._dom
Line 43: 
Line 44:     def firstElementByTagName(self, tagName):
this should be private (unless expected to be used out of __init__
Line 45:         elements = self._dom.childNodes[0].getElementsByTagName(tagName)
Line 46:         return elements[0] if elements else None
Line 47: 
Line 48:     @property


-- 
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud at kohlvanwijngaarden.nl>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <svinota.saveliev at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list