Change in vdsm[ovirt-3.5]: jsonrpc: default args values in wrong order

ybronhei at redhat.com ybronhei at redhat.com
Tue Oct 7 09:57:08 UTC 2014


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: jsonrpc: default args values in wrong order
......................................................................


jsonrpc: default args values in wrong order

Default arguments values of a method were passed in wrong order due to
wrong if condition.


Change-Id: I4e256468833851cd4ce866297de916332a560f2f
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1148499
Reviewed-on: http://gerrit.ovirt.org/33882
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M tests/bridgeTests.py
M vdsm/rpc/Bridge.py
2 files changed, 34 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, but someone else must approve



-- 
To view, visit http://gerrit.ovirt.org/33882
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e256468833851cd4ce866297de916332a560f2f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list