Change in vdsm[master]: vdsm: introduce hostdev module

fromani at redhat.com fromani at redhat.com
Mon Oct 6 13:03:25 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vdsm: introduce hostdev module
......................................................................


Patch Set 13: Code-Review-1

(7 comments)

quite good, almost there. A few minor notes inside, nothing big.
-1 for visibility

Do Bridge.py needs to be updated - read: does this work with json-rpc?
Not sure, just asking.

http://gerrit.ovirt.org/#/c/32313/13/tests/hostdevTests.py
File tests/hostdevTests.py:

Line 138:                                   u'usb_1_1':
Line 139:                                   {'params': DEVICES_PARSED['usb_1_1']}}}
Line 140: 
Line 141: 
Line 142: class ConfStub(object):
in a later patch: let's move them in a common module (vmfakelib?)
Line 143: 
Line 144:     def __init__(self, conf):
Line 145:         self.conf = conf
Line 146: 


Line 148: VirNodeDeviceStub
in a later patch: let's move them in a common module (vmfakelib?)


Line 443:     def testListByCaps(self, caps):
Line 444:         devices = hostdev.list_by_caps(ConnectionStub.VMCONTAINER, caps)
Line 445: 
Line 446:         for cap in caps:
Line 447:             print DEVICES_BY_CAPS[cap].keys()
please no prints...
Line 448:             print devices.keys()
Line 449:             self.assertTrue(set(DEVICES_BY_CAPS[cap].keys()).


http://gerrit.ovirt.org/#/c/32313/13/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3740: # @vendor_id:       Hexadecimal representation of the vendor
Line 3741: #
Line 3742: # @vendor:          String representation of the vendor
Line 3743: #
Line 3744: # Since: 4.16.0
4.17.0?
Line 3745: ##
Line 3746: {'type': 'HostDeviceParams',
Line 3747:  'data': {'capability': 'str', 'iommu_group': 'uint',
Line 3748:           'parent': 'str', 'product_id': 'str', 'product': 'str',


Line 3756: # @vmId:            The VM UUID
Line 3757: #
Line 3758: # @params:          Properties of the device
Line 3759: #
Line 3760: # Since: 4.16.0
ditto
Line 3761: ##
Line 3762: {'type': 'HostDevice',
Line 3763:  'data': {'vmId': 'UUID', 'params': 'HostDeviceParams'}}
Line 3764: 


Line 3768: # Mapping of devices to their assignments
Line 3769: #
Line 3770: # @deviceName:      Name of the device
Line 3771: #
Line 3772: # Since: 4.16.0
ditto
Line 3773: ##
Line 3774: {'type': 'HostDevices',
Line 3775:  'data': {'deviceName': 'HostDevice'}}
Line 3776: 


Line 3784: # Returns:
Line 3785: # A list of devices on the host
Line 3786: #
Line 3787: # Since: 4.16.0
Line 3788: ##
ditto
Line 3789: {'command': {'class': 'Host', 'name': 'hostdevListByCaps'},
Line 3790:  'data': {'caps': ['str']},
Line 3791:  'returns': ['HostDevices']}
Line 3792: 


-- 
To view, visit http://gerrit.ovirt.org/32313
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2bba96db5be180d00cb74fb89b10c5b09e5bd180
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vdelima at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list