Change in vdsm[master]: netinfotests: Do not assume the existence of /var/lib/vdsm/b...

osvoboda at redhat.com osvoboda at redhat.com
Fri Oct 3 13:48:43 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfotests: Do not assume the existence of /var/lib/vdsm/bonding-defaults.json
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33766/2/tests/netinfoTests.py
File tests/netinfoTests.py:

Line 300:         self.assertIn('valid2', dhcp4)
Line 301:         self.assertNotIn('expired', dhcp4)
Line 302:         self.assertNotIn('expired2', dhcp4)
Line 303: 
Line 304:     @MonkeyPatch(netinfo, 'BONDING_DEFAULTS', '../vdsm/bonding-defaults.json')
> Please verify that it flies also when run via vdsm-tests.rpm installed
I does not as it is nontrivial to go to /var/lib/vdsm from /usr/share/vdsm/tests.
Line 305:     @ValidateRunningAsRoot
Line 306:     @RequireBondingMod
Line 307:     def testGetBondingOptions(self):
Line 308:         INTERVAL = '12345'


-- 
To view, visit http://gerrit.ovirt.org/33766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ec872739729e11ff9e4a9d30cdac36733d60bae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list