Change in vdsm[master]: tool: avoid swallowing errors in seboolsetup calls.

Alon Bar-Lev alonbl at redhat.com
Fri Oct 3 05:20:50 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: tool: avoid swallowing errors in seboolsetup calls.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/33737/2/vdsm.spec.in
File vdsm.spec.in:

Line 752: 
Line 753: %post
Line 754: %{_bindir}/vdsm-tool configure --module sanlock --force >/dev/null
Line 755: if /usr/sbin/selinuxenabled; then
Line 756:     %{_bindir}/vdsm-tool sebool-config
> In that case with and without this patch the user would fail at runtime whe
so if it is part of configure why do we need it here?
Line 757: fi
Line 758: # set the vdsm "secret" password for libvirt
Line 759: %{_bindir}/vdsm-tool set-saslpasswd
Line 760: 


-- 
To view, visit http://gerrit.ovirt.org/33737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8b6d43954347f3aa2ce671131c1917d57d53fddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list