Change in vdsm[ovirt-3.5]: Moving python_sitearch to python_sitelib

ybronhei at redhat.com ybronhei at redhat.com
Thu Oct 2 18:26:04 UTC 2014


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/33738

to review the following change.

Change subject: Moving python_sitearch to python_sitelib
......................................................................

Moving python_sitearch to python_sitelib

VDSM uses pure python code, therefore there is no need to use
specific sitearch at all while installation vdsm-python files

Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1141669
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33711
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M configure.ac
M vdsm.spec.in
2 files changed, 41 insertions(+), 41 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/33738/1

diff --git a/configure.ac b/configure.ac
index 3aae03e..9938ba1 100644
--- a/configure.ac
+++ b/configure.ac
@@ -148,7 +148,7 @@
 AC_SUBST([vdsmhooksdir], ['${vdsmexecdir}/hooks'])
 AC_SUBST([vdsmtsdir], ['${sysconfdir}/pki/vdsm'])
 AC_SUBST([vdsmrepo], ['/rhev/data-center'])
-AC_SUBST([vdsmpylibdir], ['${pyexecdir}/vdsm'])
+AC_SUBST([vdsmpylibdir], ['${pythondir}/vdsm'])
 AC_SUBST([vdsmtooldir], ['${vdsmpylibdir}/tool'])
 AC_SUBST([configuratorsdir], ['${vdsmtooldir}/configurators'])
 AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 4f822e4..3e42f37 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -1188,49 +1188,49 @@
 %defattr(-, root, root, -)
 %{_mandir}/man1/vdsm-tool.1*
 %{_bindir}/vdsm-tool
-%dir %{python_sitearch}/%{vdsm_name}
-%dir %{python_sitearch}/%{vdsm_name}/tool
-%{python_sitearch}/%{vdsm_name}/__init__.py*
-%{python_sitearch}/%{vdsm_name}/compat.py*
-%{python_sitearch}/%{vdsm_name}/config.py*
-%{python_sitearch}/%{vdsm_name}/constants.py*
-%{python_sitearch}/%{vdsm_name}/define.py*
-%{python_sitearch}/%{vdsm_name}/exception.py*
-%{python_sitearch}/%{vdsm_name}/ipwrapper.py*
-%{python_sitearch}/%{vdsm_name}/libvirtconnection.py*
-%{python_sitearch}/%{vdsm_name}/netinfo.py*
-%{python_sitearch}/%{vdsm_name}/netlink.py*
-%{python_sitearch}/%{vdsm_name}/profile.py*
-%{python_sitearch}/%{vdsm_name}/qemuimg.py*
-%{python_sitearch}/%{vdsm_name}/SecureXMLRPCServer.py*
-%{python_sitearch}/%{vdsm_name}/netconfpersistence.py*
-%{python_sitearch}/%{vdsm_name}/sslutils.py*
-%{python_sitearch}/%{vdsm_name}/utils.py*
-%{python_sitearch}/%{vdsm_name}/vdscli.py*
-%{python_sitearch}/%{vdsm_name}/tool/__init__.py*
+%dir %{python_sitelib}/%{vdsm_name}
+%dir %{python_sitelib}/%{vdsm_name}/tool
+%{python_sitelib}/%{vdsm_name}/__init__.py*
+%{python_sitelib}/%{vdsm_name}/compat.py*
+%{python_sitelib}/%{vdsm_name}/config.py*
+%{python_sitelib}/%{vdsm_name}/constants.py*
+%{python_sitelib}/%{vdsm_name}/define.py*
+%{python_sitelib}/%{vdsm_name}/exception.py*
+%{python_sitelib}/%{vdsm_name}/ipwrapper.py*
+%{python_sitelib}/%{vdsm_name}/libvirtconnection.py*
+%{python_sitelib}/%{vdsm_name}/netinfo.py*
+%{python_sitelib}/%{vdsm_name}/netlink.py*
+%{python_sitelib}/%{vdsm_name}/profile.py*
+%{python_sitelib}/%{vdsm_name}/qemuimg.py*
+%{python_sitelib}/%{vdsm_name}/SecureXMLRPCServer.py*
+%{python_sitelib}/%{vdsm_name}/netconfpersistence.py*
+%{python_sitelib}/%{vdsm_name}/sslutils.py*
+%{python_sitelib}/%{vdsm_name}/utils.py*
+%{python_sitelib}/%{vdsm_name}/vdscli.py*
+%{python_sitelib}/%{vdsm_name}/tool/__init__.py*
 %if 0%{?with_systemd}
-%exclude %{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%exclude %{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
 %else
-%{python_sitearch}/%{vdsm_name}/tool/load_needed_modules.py*
+%{python_sitelib}/%{vdsm_name}/tool/load_needed_modules.py*
 %endif
-%{python_sitearch}/%{vdsm_name}/tool/dummybr.py*
-%{python_sitearch}/%{vdsm_name}/tool/nwfilter.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurator.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/__init__*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/configfile.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/certificates.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/libvirt.py*
-%{python_sitearch}/%{vdsm_name}/tool/configurators/sanlock.py*
-%{python_sitearch}/%{vdsm_name}/tool/passwd.py*
-%{python_sitearch}/%{vdsm_name}/tool/restore_nets.py*
-%{python_sitearch}/%{vdsm_name}/tool/seboolsetup.py*
-%{python_sitearch}/%{vdsm_name}/tool/service.py*
-%{python_sitearch}/%{vdsm_name}/tool/transient.py*
-%{python_sitearch}/%{vdsm_name}/tool/unified_persistence.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgrade.py*
-%{python_sitearch}/%{vdsm_name}/tool/upgrade_300_networks.py*
-%{python_sitearch}/%{vdsm_name}/tool/validate_ovirt_certs.py*
-%{python_sitearch}/%{vdsm_name}/tool/vdsm-id.py*
+%{python_sitelib}/%{vdsm_name}/tool/dummybr.py*
+%{python_sitelib}/%{vdsm_name}/tool/nwfilter.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurator.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/__init__*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/configfile.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/certificates.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/libvirt.py*
+%{python_sitelib}/%{vdsm_name}/tool/configurators/sanlock.py*
+%{python_sitelib}/%{vdsm_name}/tool/passwd.py*
+%{python_sitelib}/%{vdsm_name}/tool/restore_nets.py*
+%{python_sitelib}/%{vdsm_name}/tool/seboolsetup.py*
+%{python_sitelib}/%{vdsm_name}/tool/service.py*
+%{python_sitelib}/%{vdsm_name}/tool/transient.py*
+%{python_sitelib}/%{vdsm_name}/tool/unified_persistence.py*
+%{python_sitelib}/%{vdsm_name}/tool/upgrade.py*
+%{python_sitelib}/%{vdsm_name}/tool/upgrade_300_networks.py*
+%{python_sitelib}/%{vdsm_name}/tool/validate_ovirt_certs.py*
+%{python_sitelib}/%{vdsm_name}/tool/vdsm-id.py*
 
 %files tests
 %doc %{_datadir}/%{vdsm_name}/tests/README


-- 
To view, visit http://gerrit.ovirt.org/33738
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4476626aec2e2754ab0942ad163292672ea48bd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list