Change in vdsm[master]: virt: sampling: extract disk latency calculation

fromani at redhat.com fromani at redhat.com
Thu Oct 2 09:03:48 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: sampling: extract disk latency calculation
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29952/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 596:                                   sData['flush_operations'])
Line 597:                         else (eData['flush_total_times'] -
Line 598:                               sData['flush_total_times']) /
Line 599:                              (eData['flush_operations'] -
Line 600:                               sData['flush_operations']))
> The repeating code here is the code to calculate the latency, which is the 
neat, will do.
Line 601:         return {'readLatency': str(readLatency),
Line 602:                 'writeLatency': str(writeLatency),
Line 603:                 'flushLatency': str(flushLatency)}
Line 604: 


-- 
To view, visit http://gerrit.ovirt.org/29952
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f78e2a990aefe6095dd4ff54e21ab40006c0713
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list