Change in vdsm[ovirt-3.5]: sslutils: Document M2Crypto threading initialization

danken at redhat.com danken at redhat.com
Wed Oct 1 16:47:24 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: sslutils: Document M2Crypto threading initialization
......................................................................


sslutils: Document M2Crypto threading initialization

As documented and painfully recognized long ago in, using M2Crypto in a
multi-threaded server such as Vdsm requires explicit initialization.

M2Crypto was initialized but the code was not docuemnted properly. This
lead to the initialization being removed in this patch:
http://gerrit.ovirt.org/#/c/28858/4/lib/vdsm/verifyingtransport.py

Hopefully, improved documentation and moving it to the sslutils module
will prevent such attempts in the future.

Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124
Relates-to:
http://www.heikkitoivonen.net/m2crypto/api/M2Crypto.threading-module.html
Relates-to: https://bugzilla.redhat.com/482420
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Bug-Url: https://bugzilla.redhat.com/1147487
Reviewed-on: http://gerrit.ovirt.org/33671
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/SecureXMLRPCServer.py
M lib/vdsm/sslutils.py
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/33671
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8e5f8dc4662e16ba7e39f60336819750e1366124
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list