Change in vdsm[ovirt-3.5]: ssl: ssl_accept blocks after reboot

nsoffer at redhat.com nsoffer at redhat.com
Wed Oct 1 14:40:54 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: ssl: ssl_accept blocks after reboot
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.ovirt.org/#/c/33643/2/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 25: DEFAULT_ACCEPT_TIMEOUT = 5
Line 26: 
Line 27: # M2Crypto.threading needs initialization.
Line 28: # See https://bugzilla.redhat.com/482420
Line 29: threading.init()
Why this is new code? I move this code here few moth ago, after you deleted in one of your patches.

Please separate this to a new patch and explain this change.
Line 30: 
Line 31: 
Line 32: class SSLSocket(object):
Line 33:     def __init__(self, connection):


Line 117: 
Line 118:         try:
Line 119:             client.setup_ssl()
Line 120:             client.set_accept_state()
Line 121:             client.settimeout(self.accept_timeout)
accept does not work in non-blocking mode?

This is really bad for a non blocking server.
Line 122:             client.accept_ssl()
Line 123:             client.settimeout(None)
Line 124:         except SSL.SSLError as e:
Line 125:             raise SSL.SSLError("%s, client %s" % (e, address[0]))


-- 
To view, visit http://gerrit.ovirt.org/33643
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list