Change in vdsm[master]: ssl: ssl_accept blocks after reboot
danken at redhat.com
danken at redhat.com
Wed Oct 1 13:33:25 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: ssl: ssl_accept blocks after reboot
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/33611/4/tests/sslTests.py
File tests/sslTests.py:
Line 114: server.server.socket.accept_timeout = 1
Line 115: timeout = server.server.socket.accept_timeout + 1
Line 116: server.start()
Line 117: try:
Line 118: client_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
nit picking again: please use
with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as client_socket
and drop the close() on finally. client_socket may not be defined there.
Line 119: client_socket.settimeout(timeout)
Line 120: client_socket.connect((HOST, server.port))
Line 121: # Wait for data that will never arrive.
Line 122: # This will return successfuly if the other side closes the
--
To view, visit http://gerrit.ovirt.org/33611
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I759436b5bfb6c2334d253d12806258cbe1c3720f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list