Change in vdsm[master]: networkTests: Make DEFROUTE controllable so the system's gat...

osvoboda at redhat.com osvoboda at redhat.com
Fri Nov 28 14:05:48 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: Make DEFROUTE controllable so the system's gateway is preserved
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35701/1/tests/functional/dhcp.py
File tests/functional/dhcp.py:

Line 85:         self._pid_file = os.path.join(tmp_dir, 'test.pid')
Line 86:         self.pid = None
Line 87:         self.lease_file = os.path.join(tmp_dir, 'test.lease')
Line 88:         cmd = [_DHCLIENT_BINARY.cmd, '-v', '-1',
Line 89:                '-cf', self._conf_file, '-pf', self._pid_file,
> Done
Toni, thanks :-)
Line 90:                '-lf', self.lease_file, '-timeout', str(_DHCLIENT_TIMEOUT)]
Line 91:         if not default_route:
Line 92:             # Instruct Fedora/EL's dhclient-script not to set gateway on iface
Line 93:             cmd += ['-e', 'DEFROUTE=no']


-- 
To view, visit http://gerrit.ovirt.org/35701
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c0210b188feec45d151060d5cadaefe1ed6dc99
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list