Change in vdsm[master]: libnl: workaround for _rtnl_link_get_kernel on el6

danken at redhat.com danken at redhat.com
Fri Nov 28 13:28:15 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: libnl: workaround for _rtnl_link_get_kernel on el6
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/35518/3/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 141: 
Line 142: def _get_link(name=None, index=0, sock=None):
Line 143:     """ If defined both name and index, index is primary """
Line 144:     NLE_SUCCESS = 0
Line 145:     NLE_INVAL = 7
> This will not change for any of our supported platforms. El6.6 will continu
I want this code to survive to el6.7, too.

Ack for checking

  -err in (NLE_INVAL, NLE_NOTSUP)
Line 146: 
Line 147:     if name is None and index == 0:
Line 148:         raise ValueError('Must specify either a name or an index')
Line 149:     link = c_void_p()


-- 
To view, visit http://gerrit.ovirt.org/35518
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If16ea9321669256a1881dccdaed10dda7e6b7379
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list