Change in vdsm[master]: drv_name: Make drv_name support unicode types
danken at redhat.com
danken at redhat.com
Fri Nov 28 12:29:52 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: drv_name: Make drv_name support unicode types
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35471/4/tests/ipwrapperTests.py
File tests/ipwrapperTests.py:
Line 209: self.assertEqual(ipwrapper.drv_name(self._bridge.devName),
Line 210: ipwrapper.LinkType.BRIDGE)
Line 211:
Line 212: def testUtf8BridgeEthtoolDrvinfo(self):
Line 213: devName_as_unicode = u'test-トトロ'
this tiny "u" prefix is too delicate to understand, and a string is needlessly duplicated.
how about
self._unicode_bridge.devName.decode('utf8')
?
Line 214: self.assertEqual(ipwrapper.drv_name(devName_as_unicode),
Line 215: ipwrapper.LinkType.BRIDGE)
Line 216:
Line 217: def testTogglePromisc(self):
--
To view, visit http://gerrit.ovirt.org/35471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic705eaaad22fb1ed56bca3363a3559ee1b13d63f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list