Change in vdsm[master]: network: Make vdsmd addNetwork use supervdsmd setupNetworks

danken at redhat.com danken at redhat.com
Fri Nov 28 00:41:56 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: network: Make vdsmd addNetwork use supervdsmd setupNetworks
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35090/2//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: addNetwork is part of a very old and deprecated API that we have to
Line 10: eventually shed off in the next major release. It makes sense to
Line 11: just make an adapter so that we can simplify network.api to keep
Line 12: a single entry point.
in a separate patch, please mark addNet, delNet and editNet as deprecated, so users are notified about the planned removal.
Line 13: 
Line 14: Change-Id: I5bc76dff5add1d29e8e14b86aea358de435a1997
Line 15: Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>


http://gerrit.ovirt.org/#/c/35090/2/vdsm/API.py
File vdsm/API.py:

Line 1418
Line 1419
Line 1420
Line 1421
Line 1422
I don't believe anyone else is using supervdsmServer's addNetwork. Unless I'm wrong, the function should be purged from there, too.


-- 
To view, visit http://gerrit.ovirt.org/35090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bc76dff5add1d29e8e14b86aea358de435a1997
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list