Change in vdsm[master]: vdsm: check libvirt availability at startup

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Thu Nov 27 21:28:27 UTC 2014


Michal Skrivanek has posted comments on this change.

Change subject: vdsm: check libvirt availability at startup
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35596/2//COMMIT_MSG
Commit Message:

Line 27: although unlikely, that VDSM respawns faster than
Line 28: libvirt, especially on overloaded systems.
Line 29: 
Line 30: This patch adds an explicit check about libvirt
Line 31: availability, and makes VDSM panic() if no connection
> I may miss the whole picture, but I don't see any reason to panic if libvir
Well, you can also say the right behavior is to always exit as the system is supposed to respawn at its own pace. So both approaches are right. But since we choose to exit on error elsewhere I think exitting here too is more consistent
Line 32: at all is possible.
Line 33: It must be noted that vulnerability windows
Line 34: still exists, as in theory libvirt may crash anytime
Line 35: (e.g. just after the initial connection check).


-- 
To view, visit http://gerrit.ovirt.org/35596
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36137a424427b03a5dd3f24b5a7af1af454d0a23
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list