Change in vdsm[master]: split network restoration from vdsmd.service
ibarkan at redhat.com
ibarkan at redhat.com
Wed Nov 26 12:37:08 UTC 2014
Ido Barkan has posted comments on this change.
Change subject: split network restoration from vdsmd.service
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/29441/4/vdsm/vdsm-restore-net-config
File vdsm/vdsm-restore-net-config:
Line 127: if sys.modules[cls.__module__].is_available():
Line 128: yield cls
Line 129:
Line 130:
Line 131: def _configurator_flush(conditional=False, **opts):
opts parameter deserves a coment that it is there just to conform to _configurator_flush signature, so nobody will attempt to remove it, as it is not used.
Line 132: """Flush vdsm configurations left-overs from any configurator on the system
Line 133: so that changes of configurator and persistence system are smooth."""
Line 134: if (conditional and upgrade._upgrade_needed(
Line 135: unified_persistence.UpgradeUnifiedPersistence)):
--
To view, visit http://gerrit.ovirt.org/29441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70cdf1e8a1e7063ec850081ac6199728d4cde381
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list