Change in vdsm[master]: External hypervisor VMs integration
fromani at redhat.com
fromani at redhat.com
Wed Nov 26 07:48:55 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: External hypervisor VMs integration
......................................................................
Patch Set 27:
(1 comment)
http://gerrit.ovirt.org/#/c/33309/27/vdsm/v2v.py
File vdsm/v2v.py:
Line 22: from virt import vmstatus
Line 23: from vdsm import libvirtconnection
Line 24:
Line 25:
Line 26: class InvalidVMConfiguration(ValueError):
> Subclassing ValueError make it possible that code looking for ValueError (s
This was explicitely request by Saggi in a previous review:
http://gerrit.ovirt.org/#/c/33309/19/vdsm/v2v.py,cm
Line 27: ''' Unexpected value while parsing libvirt domain xml '''
Line 28: def __init__(self, field_name, bad_value):
Line 29: ValueError.__init__(self, "Invalid %s value: '%r'" % (field_name,
Line 30: bad_value))
--
To view, visit http://gerrit.ovirt.org/33309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dcfb860626a844d1d08590274b508519a33f4a3
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list