Change in vdsm[master]: storage: Search only the current image for children

Federico Simoncelli fsimonce at redhat.com
Tue Nov 25 16:49:11 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: storage: Search only the current image for children
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35096/1//COMMIT_MSG
Commit Message:

Line 12: problem is that deleteVolumes takes an exclusive lock on the image
Line 13: namespace only.  If deletes are active on other images at the same time
Line 14: we'll get errors with missing files.
Line 15: 
Line 16: The code mistakenly claims that children can be in any image on the
> False. Templates have children _only_ in other images.
Feel free to elaborate on why bz1069610#c3 is wrong.

Having two concurrent deleteImage calls will generate two "grep" processes with cached *.meta files to scan. One of the two calls will fail (No such file or directory) because one .meta file was removed by the other one.
Line 17: storage domain.  It appears that they are in fact limited to the same
Line 18: image.  Therefore, the simplest resolution is to limit the search for
Line 19: children to the current image.
Line 20: 


-- 
To view, visit http://gerrit.ovirt.org/35096
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ef9012cee3a8cb891926510c10ecc47b7cddaa1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list