Change in vdsm[master]: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrappe...
danken at redhat.com
danken at redhat.com
Tue Nov 25 13:02:31 UTC 2014
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Replace getVlanDevice/ID in bootstrap with ipwrapper.getLink
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/35360/1/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 328: nics = []
Line 329: for iface in ports(bridge):
Line 330: if iface in vlans():
Line 331: iface = _getVlanDevice(iface)
Line 332: vlan = _getVlanID(iface)
> there is 'eth0.100' in vlans(); getVlanDevice('eth0.100') returns 'eth0'; a
I believe that Ondrej refers to http://gerrit.ovirt.org/18182 which introduced a bug: iface variable is being overridden by the output of _getVlanDevice.
Line 333: if iface in bondings():
Line 334: bonding = iface
Line 335: nics = slaves(iface)
Line 336: else:
--
To view, visit http://gerrit.ovirt.org/35360
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4bfb0fa3c341a517bf444832d0531b05393ae4a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list