Change in vdsm[master]: tests: add vdscli.cannonizeHostPort unit tests

mtayer at redhat.com mtayer at redhat.com
Tue Nov 25 12:21:03 UTC 2014


mooli tayer has posted comments on this change.

Change subject: tests: add vdscli.cannonizeHostPort unit tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35270/2/tests/vdsClientTests.py
File tests/vdsClientTests.py:

Line 522: 
Line 523: 
Line 524: class CannonizeHostPortTest(TestCaseBase):
Line 525: 
Line 526:     def assertIsIpAddressWithPort(self, addrWithPort):
> Does this assert apply to an ip address or hostname or both?
_assertIsIpAddressWithPort and move below with other _?
Line 527:         try:
Line 528:             addr, port = addrWithPort.split(':')
Line 529:         except ValueError:
Line 530:             raise AssertionError('%s is not a valid IP address:' %


-- 
To view, visit http://gerrit.ovirt.org/35270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26ff1ccb6b258c7adf7014fb9bc8c09cb3f32f1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list