Change in vdsm[master]: vm: log exceptional monitor unresponsive case

danken at redhat.com danken at redhat.com
Tue Nov 25 11:20:54 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: log exceptional monitor unresponsive case
......................................................................


vm: log exceptional monitor unresponsive case

In past ages we added an explicit case to mark
monitor unresponsive.

This case may be no long relevant. In order
to gather evidence against or supporting
this hypotesis, add an explicit log line
when this case is applied.

Also, extract the relevant code in a helper
method, and add a couple of unit tests.

Change-Id: I04b88513d319d3f4530aa6d9f1b4a1c783b33347
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/33870
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/testlib.py
M tests/vmTests.py
M vdsm/virt/vm.py
3 files changed, 55 insertions(+), 4 deletions(-)

Approvals:
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/33870
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I04b88513d319d3f4530aa6d9f1b4a1c783b33347
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list