Change in vdsm[master]: gluster: add createBrick verb

barumuga at redhat.com barumuga at redhat.com
Tue Nov 25 10:33:20 UTC 2014


Bala.FA has posted comments on this change.

Change subject: gluster: add createBrick verb
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/35498/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 66:     blivetEnv.reset()
Line 67:     devices = blivetEnv.devices
Line 68: 
Line 69:     if not name:
Line 70:         name = "lvm%s" % (random.randint(1, 1000))
if brick name is not given, define brick name as 'brickN' where N is next number from existing bricks.  bricks are under /rhs in downstream and upstream its /gluster directory
Line 71:     for disk in devices:
Line 72:         if disksList and disk.name not in disksList:
Line 73:             continue
Line 74:         totalSize += disk.size


Line 74:         totalSize += disk.size
Line 75:         blivetEnv.initializeDisk(disk)
Line 76:         # "create device dev"
Line 77:         pv = blivetEnv.newPartition(fmt_type="lvmpv", grow=True,
Line 78:                                     parents=[disk])
Create new partition only if the given device is a disk else use it as is.
Line 79:         pvList.append(pv)
Line 80:         blivetEnv.createDevice(pv)
Line 81:         time.sleep(1)
Line 82: 


-- 
To view, visit http://gerrit.ovirt.org/35498
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list