Change in vdsm[master]: hba: Rescan using SCSI layer

Federico Simoncelli fsimonce at redhat.com
Mon Nov 24 22:16:56 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: hba: Rescan using SCSI layer
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.ovirt.org/#/c/34245/5/vdsm/storage/fc-scan
File vdsm/storage/fc-scan:

Line 63:     def run(self):
Line 64:         try:
Line 65:             path = "/sys/class/scsi_host/%s/scan" % self.host
Line 66:             log.debug("Scanning %s", path)
Line 67:             start = time.time()
> Why do we need monotonic timer for debugging? It is unlikely that the syste
I'd slightly prefer os.times()[4] despite of its lower resolution, but anyway since this is just for logging I think it could be considered just "taste".
Line 68:             fd = os.open(path, os.O_WRONLY)
Line 69:             try:
Line 70:                 os.write(fd, "- - -")
Line 71:             finally:


Line 100:         sys.exit(0)
Line 101: 
Line 102:     scans = []
Line 103: 
Line 104:     for host in hosts:
> no, I don't want to add another dependency for such trivial code.
+1 for no other dependencies
Line 105:         s = Scan(host)
Line 106:         s.start()
Line 107:         scans.append(s)
Line 108: 


-- 
To view, visit http://gerrit.ovirt.org/34245
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7deb3047f1b75c4c65d59602b908835515290993
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list