Change in vdsm[master]: lvm: Disable chown hack for EL6

danken at redhat.com danken at redhat.com
Mon Nov 24 17:24:55 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: lvm: Disable chown hack for EL6
......................................................................


lvm: Disable chown hack for EL6

Testing EL6 revealed that the new vdsm lvm udev rules required for EL7
introduced a race which causes createVolume to fail randomly on some
machines.

Since commit 9240b8c5782 (lvm: Do not use udev to set permissions on
vdsm images), devices are created with default permissions - root:disk.
Then udev run chown which set the permissions to vdsm:qemu.  Because of
udev "watch" feature, this permission dance happens twice when creating
a logical volume:

    root:disk -> vdsm:qemu -> root:disk -> vdsm:qemu

Typically when lvcreate returns the permissions changes are done, but
sometimes it may return while the events are processed. Then when we run
qemu-img, it fail because the disk permissions are not vdsm:qemu.

On EL6 we don't need to use the chown hack; We used it because it looked
like a simple solution that works everywhere. So now we use the old udev
rules format on EL6, and the new format (chown hack) on EL7 and Fedora.

By default, we build the old udev format. To enable the new format,
configure with --enable-chown-hack. The spec enables the chown hack
on EL7 and Fedora trough configure.

To create a different rule depending on the configuration, the udev rule
is generated now by a python script.

On EL7 using our chown hack, the race does not exist. We also verified
that using a script creating 600 disks, and using automated QE tests.

Change-Id: I7d84c986511d9cfc7695a79ef5944edf70050934
Bug-Url: https://bugzilla.redhat.com/1160620
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35440
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M .gitignore
M configure.ac
M vdsm.spec.in
M vdsm/storage/Makefile.am
R vdsm/storage/vdsm_lvm_rules.template.in
5 files changed, 53 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/35440
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d84c986511d9cfc7695a79ef5944edf70050934
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list