Change in vdsm[master]: tests: add vdscli.cannonizeHostPort unit tests

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 24 14:06:09 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: add vdscli.cannonizeHostPort unit tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/35270/2/tests/vdsClientTests.py
File tests/vdsClientTests.py:

Line 589:         try:
Line 590:             port = int(port_str)
Line 591:         except ValueError:
Line 592:             raise AssertionError('malformed port: %s' % port_str)
Line 593:         if port <= 0 or port >= 2**16:
> is port 0 is valid for binding?
Well it is not very useful for vdsm, but it is valid (the kernel will choose a port for you)
Line 594:             raise AssertionError('malformed port: %s' % port_str)
Line 595: 
Line 596: 
Line 597: def _isIPv4Address(address):


-- 
To view, visit http://gerrit.ovirt.org/35270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26ff1ccb6b258c7adf7014fb9bc8c09cb3f32f1a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list