Change in vdsm[master]: tests: add vdscli.cannonizeHostPort unit tests

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 24 10:17:03 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: tests: add vdscli.cannonizeHostPort unit tests
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35270/1/tests/vdsClientTests.py
File tests/vdsClientTests.py:

Line 539:         # TODO: validate well formed ipv4 or v6
Line 540:         self._assertValidPort(port)
Line 541: 
Line 542:     def testNoArguments(self):
Line 543:         self.assertIsIpAddressWithPort(vdscli.cannonizeHostPort())
> What I'm trying to do here is to just check that the return value of cannon
Ok
Line 544: 
Line 545:     def testNoneArgument(self):
Line 546:         self.assertIsIpAddressWithPort(vdscli.cannonizeHostPort(None))
Line 547: 


-- 
To view, visit http://gerrit.ovirt.org/35270
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26ff1ccb6b258c7adf7014fb9bc8c09cb3f32f1a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list