Change in vdsm[master]: clientIF: Use a weakref.proxy when registering contEIOVMs

nsoffer at redhat.com nsoffer at redhat.com
Fri Nov 21 20:34:02 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: Use a weakref.proxy when registering contEIOVMs
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/35436/1/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 78:         self._shutdownSemaphore = threading.Semaphore()
Line 79:         self.irs = irs
Line 80:         if self.irs:
Line 81:             cb = partial(clientIF.contEIOVms, proxy(self))
Line 82:             self.irs.registerDomainStateChangeCallback(cb)
> This does not work, because cb is collected when __init__ is finished, so t
See http://gerrit.ovirt.org/35438
Line 83:         self.log = log
Line 84:         self._recovery = True
Line 85:         self.channelListener = Listener(self.log)
Line 86:         self._generationID = str(uuid.uuid4())


-- 
To view, visit http://gerrit.ovirt.org/35436
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib06967b26fc9ace41e5f8305a8fadafbbb0fc4e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list