Change in vdsm[ovirt-3.5]: jsonrpc: have simplejson as soft dependency

fromani at redhat.com fromani at redhat.com
Fri Nov 21 09:11:37 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: have simplejson as soft dependency
......................................................................


Patch Set 2: Verified+1

* Changes: fixed the ordering of dependencies in spec file.

* Verification

* RHEL 7.0:
- VDSM does not depends on simplejson, and is installed cleanly on a system without simplejson

BENji> 10:02:27 fromani [~]$ rpm -qa | grep -i json
vdsm-jsonrpc-4.16.7-69.git9e2dc5a.el7.noarch
json-c-0.11-4.el7_0.x86_64
rsyslog-mmjsonparse-7.4.7-7.el7_0.x86_64
vdsm-yajsonrpc-4.16.7-69.git9e2dc5a.el7.noarch
BENji> 10:02:29 fromani [~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.0 (Maipo)
BENji> 10:02:41 fromani [~]$ rpm -qR vdsm-jsonrpc
python(abi) = 2.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
vdsm-python = 4.16.7-69.git9e2dc5a.el7
vdsm-yajsonrpc = 4.16.7-69.git9e2dc5a.el7
rpmlib(PayloadIsXz) <= 5.2-1
BENji> 10:02:48 fromani [~/build/vdsmdx0fj6/rpm/RPMS]$ rpm -qR vdsm-yajsonrpc
python >= 2.6
python(abi) = 2.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

- jsonrpc works:
BENji> 10:04:34 root [~]$ ./jsonrpc Host.getCapabilities | tail
        "rngSources": [
            "random"
        ], 
        "operatingSystem": {
            "release": "1.el7", 
            "version": "7.0", 
            "name": "RHEL"
        }
    }
}

- jsonrpc is using vdsm stdlib package:
BENji> 10:04:37 root [~]$ ps aux | grep vdsm
root      8767  0.0  0.1 583716 26060 ?        S<sl 10:02   0:00 /usr/bin/python /usr/share/vdsm/supervdsmServer --sockfile /var/run/vdsm/svdsm.sock
vdsm      9077  3.7  0.3 2015748 49576 ?       S<sl 10:03   0:04 /usr/bin/python /usr/share/vdsm/vdsm
root      9239  0.0  0.0 112644   968 pts/1    R+   10:05   0:00 grep --color=auto vdsm
BENji> 10:05:17 root [~]$ cat /proc/9077/maps | grep -i json
7fae7161e000-7fae71626000 r-xp 00000000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7fae71626000-7fae71825000 ---p 00008000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7fae71825000-7fae71826000 r--p 00007000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7fae71826000-7fae71827000 rw-p 00008000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so

* RHEL 6.6
- VDSM DOES depend on simplejson
TOji> 10:07:02 fromani [~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.6 (Santiago)
TOji> 10:08:16 fromani [~]$ rpm -qa | grep -i json
python-simplejson-2.0.9-3.1.el6.x86_64
vdsm-yajsonrpc-4.16.7-68.git278471b.el6.noarch
vdsm-jsonrpc-4.16.7-68.git278471b.el6.noarch
TOji> 10:08:25 fromani [~]$ rpm -qR vdsm-jsonrpc
python(abi) = 2.6
python-ordereddict  
python-simplejson >= 2.0.9
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
vdsm-python = 4.16.7-68.git278471b.el6
vdsm-yajsonrpc = 4.16.7-68.git278471b.el6
rpmlib(PayloadIsXz) <= 5.2-1
TOji> 10:08:29 fromani [~]$ rpm -qR vdsm-yajsonrpc
python >= 2.6
python(abi) = 2.6
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

- jsonrpc works
TOji> 10:09:27 root [~/VMDefs]$ ./jsonrpc Host.getCapabilities | tail
        "rngSources": [
            "random"
        ], 
        "operatingSystem": {
            "release": "6.6.0.2.el6", 
            "version": "6Server", 
            "name": "RHEL"
        }
    }
}

- jsonrpc IS using simplejson package
TOji> 10:09:30 root [~/VMDefs]$ ps aux | grep vdsm
root      2635  0.0  0.0  11340   696 ?        S<   09:49   0:00 /bin/bash -e /usr/share/vdsm/respawn --minlifetime 10 --daemon --masterpid /var/run/vdsm/supervdsm_respawn.pid /usr/share/vdsm/supervdsmServer --sockfile /var/run/vdsm/svdsm.sock --pidfile /var/run/vdsm/supervdsmd.pid
root      2638  0.0  0.1 576216 27620 ?        S<l  09:49   0:00 /usr/bin/python /usr/share/vdsm/supervdsmServer --sockfile /var/run/vdsm/svdsm.sock --pidfile /var/run/vdsm/supervdsmd.pid
vdsm      3671  0.0  0.0   9236   680 ?        S<   09:50   0:00 /bin/bash -e /usr/share/vdsm/respawn --minlifetime 10 --daemon --masterpid /var/run/vdsm/respawn.pid /usr/share/vdsm/vdsm --pidfile /var/run/vdsm/vdsmd.pid
vdsm      3673  4.3  0.2 2106996 48460 ?       S<l  09:50   0:51 /usr/bin/python /usr/share/vdsm/vdsm --pidfile /var/run/vdsm/vdsmd.pid
root      4981  0.0  0.0 103256   852 pts/0    S+   10:09   0:00 grep vdsm
TOji> 10:09:56 root [~/VMDefs]$ cat /proc/3673/maps | grep -i json
7f4e209be000-7f4e209c1000 r-xp 00000000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f4e209c1000-7f4e20bc0000 ---p 00003000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f4e20bc0000-7f4e20bc1000 rw-p 00002000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f4e2134c000-7f4e21353000 r-xp 00000000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so
7f4e21353000-7f4e21553000 ---p 00007000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so
7f4e21553000-7f4e21554000 rw-p 00007000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so

-- 
To view, visit http://gerrit.ovirt.org/35405
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11c05cff5b1cc3727653fa4ce210a76fcadf5628
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list