Change in vdsm[master]: jsonrpc: have simplejson as soft dependency

danken at redhat.com danken at redhat.com
Thu Nov 20 14:33:32 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpc: have simplejson as soft dependency
......................................................................


jsonrpc: have simplejson as soft dependency

In commit ec58bca5cb18 we added dependency to
the external simplejson package to gain some speed,
especially on RHEL/Centos 6.x.

We discovered the hard way that python-simplejson
was moved out of the base system in RHEL/CentOS 7,
and put into the EPEL repository.
This is alone makes ec58bca5cb18 not good enough.

We still want to get the JSON codec speedups, so
to this patch
* moves the requires to RHEL/Centos 6.x only
* makes simplejson a soft dependency.

Change-Id: I11c05cff5b1cc3727653fa4ce210a76fcadf5628
Bug-Url: https://bugzilla.redhat.com/1155146
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/35354
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/compat.py
M lib/yajsonrpc/__init__.py
M vdsm.spec.in
3 files changed, 16 insertions(+), 3 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit http://gerrit.ovirt.org/35354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I11c05cff5b1cc3727653fa4ce210a76fcadf5628
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list