Change in vdsm[master]: jsonrpc: have simplejson as soft dependency

fromani at redhat.com fromani at redhat.com
Thu Nov 20 13:11:25 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: jsonrpc: have simplejson as soft dependency
......................................................................


Patch Set 2: Verified+1

Verification:

* RHEL 6.6
TOji> 14:03:20 fromani [~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 6.6 (Santiago)
TOji> 14:03:34 fromani [~]$ rpm -qR vdsm-jsonrpc | grep json
python-simplejson >= 2.0.9
vdsm-yajsonrpc = 4.17.0-23.git9f3f7b4.el6

TOji> 14:05:20 root [~/VMDefs]$ ./jsonrpc Host.getCapabilities
{
    "jsonrpc": "2.0", 
    "id": "bb21f02f-2793-4c36-bdb0-8fad515cff49", 
    "result": {
        "HBAInventory": {
            "iSCSI": [
                {
                    "InitiatorName": "iqn.1994-05.com.redhat:6585f96f59c4"
                }
            ], 
            "FC": []
        }, 
        "packages2": {
            "kernel": {
                "release": "504.1.3.el6.x86_64", 
                "buildtime": 1414751830.0, 
                "version": "2.6.32"
            }, 
[snipped for brevity]

TOji> 14:06:11 root [~/VMDefs]$ ps -auxw | grep vdsm
Warning: bad syntax, perhaps a bogus '-'? See /usr/share/doc/procps-3.2.8/FAQ
vdsm      5354  0.0  0.0   9236   672 ?        S<   13:59   0:00 /bin/bash -e /usr/share/vdsm/respawn --minlifetime 10 --daemon --masterpid /var/run/vdsm/respawn.pid /usr/share/vdsm/vdsm --pidfile /var/run/vdsm/vdsmd.pid
vdsm      5357  0.5  0.3 2082644 53516 ?       S<l  13:59   0:02 /usr/bin/python /usr/share/vdsm/vdsm --pidfile /var/run/vdsm/vdsmd.pid
root      5940  0.0  0.0 103256   848 pts/0    S+   14:06   0:00 grep vdsm
TOji> 14:06:27 root [~/VMDefs]$ cat /proc/5357/maps | grep json
7f567e460000-7f567e463000 r-xp 00000000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f567e463000-7f567e662000 ---p 00003000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f567e662000-7f567e663000 rw-p 00002000 fd:00 2493240                    /usr/lib64/python2.6/lib-dynload/_json.so
7f567fa47000-7f567fa4e000 r-xp 00000000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so
7f567fa4e000-7f567fc4e000 ---p 00007000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so
7f567fc4e000-7f567fc4f000 rw-p 00007000 fd:00 2496366                    /usr/lib64/python2.6/site-packages/simplejson/_speedups.so

This confirms VDSM _is_ using the simplejson package and its speedups

* RHEL 7.0

BENji> 14:08:19 root [~]$ cat /etc/redhat-release 
Red Hat Enterprise Linux Server release 7.0 (Maipo)
BENji> 14:08:36 root [~]$ rpm -qR vdsm-jsonrpc | grep json
vdsm-yajsonrpc = 4.17.0-23.git9f3f7b4.el7
BENji> 14:09:24 root [~]$ ./jsonrpc Host.getCapabilities
{
    "jsonrpc": "2.0", 
    "id": "2b39262a-8587-4464-b6b7-9fdf3477b47e", 
    "result": {
        "HBAInventory": {
            "iSCSI": [
                {
                    "InitiatorName": "iqn.1994-05.com.redhat:79a140a9e0a"
                }
            ], 
            "FC": []
        }, 
        "packages2": {
            "kernel": {
                "release": "123.9.3.el7.x86_64", 
                "buildtime": 1414624600.0, 
                "version": "3.10.0"
            }, 
[snipped for brevity]

BENji> 14:10:29 root [~]$ ps -auxw | grep vdsm
root      2289  0.0  0.1 577224 25944 ?        S<sl 14:01   0:00 /usr/bin/python /usr/share/vdsm/supervdsmServer --sockfile /var/run/vdsm/svdsm.sock
vdsm      2377  0.4  0.3 2012184 50628 ?       S<sl 14:01   0:02 /usr/bin/python /usr/share/vdsm/vdsm
root      2752  0.0  0.0 112640   968 pts/0    S+   14:10   0:00 grep --color=auto vdsm
BENji> 14:10:33 root [~]$ cat /proc/2377/maps | grep json
7f5358df4000-7f5358dfc000 r-xp 00000000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7f5358dfc000-7f5358ffb000 ---p 00008000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7f5358ffb000-7f5358ffc000 r--p 00007000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
7f5358ffc000-7f5358ffd000 rw-p 00008000 fd:00 67312280                   /usr/lib64/python2.7/lib-dynload/_json.so
BENji> 14:10:43 root [~]$ rpm -qa | grep simplejson
BENji> 14:10:55 root [~]$

-- 
To view, visit http://gerrit.ovirt.org/35354
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11c05cff5b1cc3727653fa4ce210a76fcadf5628
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list