Change in vdsm[master]: network: Make vdsmd addNetwork use supervdsmd setupNetworks

ibarkan at redhat.com ibarkan at redhat.com
Wed Nov 19 10:44:24 UTC 2014


Ido Barkan has posted comments on this change.

Change subject: network: Make vdsmd addNetwork use supervdsmd setupNetworks
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/35090/1/vdsm/API.py
File vdsm/API.py:

Line 1424:                 bonds[bond]['nics'] = list(nics)
Line 1425:             else:
Line 1426:                 nics = list(nics)
Line 1427:                 if nics:
Line 1428:                     options['nic'], = nics
this is a nice trick, but not a readable one. Why not:
if len(nics) != 1:
    raise ConfigNetworkError(ERR_BAD_PARAMS, 'expected exactly on nic in a not bonded network')

or similar.
Line 1429: 
Line 1430:             try:
Line 1431:                 supervdsm.getProxy().setupNetworks(
Line 1432:                     {network: options},


-- 
To view, visit http://gerrit.ovirt.org/35090
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bc76dff5add1d29e8e14b86aea358de435a1997
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list